Skip to content

Add support for fetching project and application extensions#47

Merged
purplecabbage merged 3 commits intoadobe:masterfrom
MichaelGoberling:get-application-extensions
Jul 21, 2022
Merged

Add support for fetching project and application extensions#47
purplecabbage merged 3 commits intoadobe:masterfrom
MichaelGoberling:get-application-extensions

Conversation

@MichaelGoberling
Copy link
Copy Markdown
Contributor

This pull request proposes adding support to this library for fetching project details and application extensions from the Console API.

Description

Add implemntation for fetching project details and the new application extension integration here. These functions are consumed by the app plugin in order to determine a project's status so we can make it more difficult to overwrite a published Production App Builder application.

Related Issue

Motivation and Context

To more comprehensively integrate with the Console API and to make it harder to overwrite a published Production App Builder application.

How Has This Been Tested?

Tested locally with npm run test and linked version of aio-lib-console.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2022

Codecov Report

Merging #47 (e46d543) into master (0ee01a5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          486       498   +12     
  Branches        81        81           
=========================================
+ Hits           486       498   +12     
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee01a5...e46d543. Read the comment docs.

Copy link
Copy Markdown
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm!

@purplecabbage purplecabbage merged commit f0bded0 into adobe:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants