feat: assets-11322 add aio-cli console support for public key rotation#44
Merged
purplecabbage merged 6 commits intoadobe:masterfrom Jun 14, 2022
Merged
feat: assets-11322 add aio-cli console support for public key rotation#44purplecabbage merged 6 commits intoadobe:masterfrom
purplecabbage merged 6 commits intoadobe:masterfrom
Conversation
10 tasks
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 451 486 +35
Branches 75 81 +6
=========================================
+ Hits 451 486 +35
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add four functions to LibConsoleCLI:
getBindingsForWorkspace(orgId, project, workspace): retrieve the list of certificate bindings for the selected workspaceuploadAndBindCertificateToWorkspace(orgId, project, workspace, publicKeyPath): upload and bind a public key certificate to the service account of the selected workspacedeleteBindingFromWorkspace(orgId, project, workspace, binding): delete a binding (retrieved from getBindingsForWorkspace) from the selected workspace service accountgetCertificateFingerprint(pemCert): compute x509 fingerprint for provided public key certificateThese functions provide necessary support for
aio console:publickeycommands introduced by adobe/aio-cli-plugin-console#173Related Issue
https://jira.corp.adobe.com/browse/ASSETS-11322
Blocked by
https://jira.corp.adobe.com/browse/IOC-4292adobe/aio-lib-console#33Motivation and Context
aio consoleshould support workspace public key rotation, in combination withaio certificate:generate.How Has This Been Tested?
Tested locally with npm linked branches of:
@adobe/aio-lib-console
@adobe/aio-cli-lib-console
@adobe/aio-cli-plugin-console
Screenshots (if appropriate):
Types of changes
Checklist: