-
Notifications
You must be signed in to change notification settings - Fork 24
-circle updates to xcode 16.4 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks Steve! While we're here can we also fix the incorrect flag in the Makefile: BUILD_LIBRARIES_FOR_DISTRIBUTION (nonexistent) BUILD_LIBRARY_FOR_DISTRIBUTION |
Gemfile.lock
Outdated
|
|
||
| BUNDLED WITH | ||
| 2.2.16 | ||
| 2.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want an exact match with the bundler and cocoapods version preinstalled on the runner?
Based on the logs it looks like the preinstalled versions are:
- bundler: 2.6.9
- Cocoapods: 1.14.3
Bundler 2.6.9 is running, but your lockfile was generated with 2.7.2. Installing Bundler 2.7.2 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.7.2
Installing bundler 2.7.2
[!] The version of CocoaPods used to generate the lockfile (1.16.2) is higher than the version of the current executable (1.14.3). Incompatibility issues may arise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i updated the bundler - i'm not sure where the cocoapods comment is coming from though. we don't have 1.16.2 anywhere in Gemfile or Gemfile.lock
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nevermind - i'm an idiot 🤦
it's from Podfile.lock. i don't think it's causing us any issues right now, and that file gets updated every time we do pod update to get new versions of dependencies - i'd say if it's not causing a problem let's just leave it as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Steve! Looks great
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: