Skip to content

Conversation

@sbenedicadb
Copy link
Member

Description

  • update circle simulator to iphone 16, ios 18.5
  • update xcode version for circle builds to use 16.4.0
  • update gemfile.lock to use newer bundler version (installed by default on the circle ci resource used)
  • update makefile to use correct new version of simulator pre-launched in circle job

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe
Copy link
Contributor

Thanks Steve! While we're here can we also fix the incorrect flag in the Makefile:

BUILD_LIBRARIES_FOR_DISTRIBUTION (nonexistent)

BUILD_LIBRARY_FOR_DISTRIBUTION

Gemfile.lock Outdated

BUNDLED WITH
2.2.16
2.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want an exact match with the bundler and cocoapods version preinstalled on the runner?

Based on the logs it looks like the preinstalled versions are:

  • bundler: 2.6.9
  • Cocoapods: 1.14.3
Bundler 2.6.9 is running, but your lockfile was generated with 2.7.2. Installing Bundler 2.7.2 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.7.2
Installing bundler 2.7.2
[!] The version of CocoaPods used to generate the lockfile (1.16.2) is higher than the version of the current executable (1.14.3). Incompatibility issues may arise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated the bundler - i'm not sure where the cocoapods comment is coming from though. we don't have 1.16.2 anywhere in Gemfile or Gemfile.lock

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nevermind - i'm an idiot 🤦

it's from Podfile.lock. i don't think it's causing us any issues right now, and that file gets updated every time we do pod update to get new versions of dependencies - i'd say if it's not causing a problem let's just leave it as it is

Copy link
Contributor

@timkimadobe timkimadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve! Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants