Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event name corresponding to trackComplete() API from mediacomplete to complete #47

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

addb
Copy link
Collaborator

@addb addb commented Jul 16, 2021

and have platform parity

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested a review from cacheung July 16, 2021 20:45
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #47 (0a4d300) into dev-v3.0.1 (adcc340) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           dev-v3.0.1      #47   +/-   ##
===========================================
  Coverage       92.54%   92.54%           
===========================================
  Files              28       28           
  Lines            2159     2159           
===========================================
  Hits             1998     1998           
  Misses            161      161           

@addb addb merged commit 2467279 into adobe:dev-v3.0.1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants