Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media public api and tracker #4

Merged
merged 19 commits into from
Feb 25, 2021
Merged

Media public api and tracker #4

merged 19 commits into from
Feb 25, 2021

Conversation

addb
Copy link
Collaborator

@addb addb commented Feb 12, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #4 (9ab986d) into dev (e88354d) will increase coverage by 29.85%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##              dev       #4       +/-   ##
===========================================
+ Coverage   54.76%   84.62%   +29.85%     
===========================================
  Files           4        7        +3     
  Lines          84      273      +189     
===========================================
+ Hits           46      231      +185     
- Misses         38       42        +4

rymorale
rymorale approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@rymorale rymorale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just a few minor things to take a look at.

@addb addb merged commit ede3f2b into adobe:dev Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymorale rymorale rymorale approved these changes

@praveek praveek praveek approved these changes

@shtomar-adb shtomar-adb Awaiting requested review from shtomar-adb

@cacheung cacheung Awaiting requested review from cacheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addb @rymorale @praveek