Include code format tools #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #37 +/- ##
==========================================
+ Coverage 73.95% 74.70% +0.75%
==========================================
Files 13 13
Lines 403 411 +8
Branches 48 48
==========================================
+ Hits 298 307 +9
+ Misses 77 76 -1
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
emdobrin
reviewed
Jun 1, 2021
| } | ||
| }); | ||
| ); |
There was a problem hiding this comment.
this map can use a little help. can we simplify this by creating the inner maps in advance? - same below
| "Received unexpected event with type: " + | ||
| receivedEvent.getKey().type + | ||
| " source: " + | ||
| receivedEvent.getKey().source |
There was a problem hiding this comment.
Could use String.format for improved readability
code/edgeconsent/src/main/java/com/adobe/marketing/mobile/edge/consent/Consent.java
Show resolved
Hide resolved
emdobrin
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes code format tools to build system.
Spotless is configured to format according to Google Java Code Style, however with tab indentation, indent size of 4, and 120 line width.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: