Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging -> Main (v3.2.1) #653

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Staging -> Main (v3.2.1) #653

merged 5 commits into from
Jun 21, 2021

Conversation

kevinlind
Copy link
Contributor

Description

V3.2.1 release

  • Fixes issue in AEPIdentity where syncIdentifier and syncIdentifiers always set authentication state to unknown.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

nporter-adbe and others added 5 commits June 8, 2021 07:42
@nporter-adbe
Merge pull request #648 from adobe/main
7e2adc0 
main -> staging
@kevinlind
Fix authentication state when calling syncIdentifiers (#649)
87d6cab 
* Set authentication state as object instead of raw value in syncIdentifiers call.
Send authentication state as MobileVisitorAuthenticationState instead of Int in event data for syncIdentifiers API call. The Identity extension casts the authentication state as a MobileVisitorAuthenticationState when extracting from the event data. When using the raw value (Int) of the MobileVisitorAuthenticationState enum, the cast always fails and returns value .unknown. This fix will allow the user specified authentication state for the custom identifier in the syncIdentifiers call instead of all authentication states being unknown.

* Verify authentication state as object and not int in Identity unit tests
@kevinlind
Bump all versions to v3.2.1
5d8f1af
@kevinlind
Merge pull request #651 from kevinlind/bump-v3.2.1
b2c7cd6 
Bump all versions to v3.2.1
@kevinlind
Merge pull request #652 from adobe/dev-v3.2.1
4678cb7 
dev -> staging (3.2.1)
@nporter-adbe nporter-adbe merged commit 5ae38a2 into main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nporter-adbe nporter-adbe nporter-adbe approved these changes

@yangyansong-adbe yangyansong-adbe Awaiting requested review from yangyansong-adbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlind @nporter-adbe