Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle condition definitions that don't have values #632

Merged
merged 1 commit into from
May 20, 2021

Conversation

rymorale
Copy link
Contributor

Description

fix for issue: #630

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rymorale rymorale requested a review from shalehaha May 20, 2021 00:10
@rymorale rymorale linked an issue May 20, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #632 (6c1c753) into dev-v3.1.4 (ccf4bb6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           dev-v3.1.4     #632   +/-   ##
===========================================
  Coverage       85.30%   85.30%           
===========================================
  Files             104      104           
  Lines            4612     4613    +1     
===========================================
+ Hits             3934     3935    +1     
  Misses            678      678           

@shalehaha shalehaha merged commit ad8a261 into adobe:dev-v3.1.4 May 20, 2021
@shalehaha shalehaha added this to the v3.1.4 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONCondition.convert does not handle conditions with no values
2 participants