Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration bugs #594

Merged
merged 11 commits into from
Mar 31, 2021
Merged

Fix migration bugs #594

merged 11 commits into from
Mar 31, 2021

Conversation

nporter-adbe
Copy link
Contributor

Description

  • Fixes a bug where the Identity ECID wasn't migrated from v4 & v5
  • Fixes a bug where some lifecycle data (dates) weren't migrated properly
  • Fixes a bug in AnyCodable when attempting to encode nil

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #594 (7bfb205) into dev-v3.1.0 (84f7c9c) will increase coverage by 0.08%.
The diff coverage is 94.12%.

@@              Coverage Diff               @@
##           dev-v3.1.0     #594      +/-   ##
==============================================
+ Coverage       85.27%   85.34%   +0.08%     
==============================================
  Files             102      102              
  Lines            4541     4544       +3     
==============================================
+ Hits             3872     3878       +6     
+ Misses            669      666       -3     

@shalehaha shalehaha changed the base branch from dev-v3.1.0 to staging March 31, 2021 14:53
@shalehaha shalehaha merged commit e3ea968 into adobe:staging Mar 31, 2021
@shalehaha shalehaha linked an issue Apr 1, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test data migration from v4 and v5 SDK
2 participants