Add edge prefix to eventTypes #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdobrin
changed the title
nporter-adbe
approved these changes
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.1 #573 +/- ##
===========================================
Coverage 85.04% 85.04%
===========================================
Files 101 101
Lines 4471 4471
===========================================
Hits 3802 3802
Misses 669 669 |
|
cc @pfransenadb |
emdobrin
commented
Mar 12, 2021
| @@ -41,6 +41,6 @@ public class EventType: NSObject { | |||
| public static let genericPii = "com.adobe.eventType.generic.pii" | |||
| public static let genericData = "com.adobe.eventType.generic.data" | |||
| public static let edge = "com.adobe.eventType.edge" | |||
| public static let consent = "com.adobe.eventType.consent" | |||
| public static let edgeConsent = "com.adobe.eventType.edgeConsent" | |||
There was a problem hiding this comment.
I would prefer to keep this consent, but I also feel that if we do that it will not be consistent with the shared state name proposals and module name.
PravinPK
approved these changes
Mar 12, 2021
kevinlind
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in AMSDK-11139