Default Header Locale Formatter #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type as we are doing it now.
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.1 #520 +/- ##
==============================================
+ Coverage 87.69% 87.75% +0.05%
==============================================
Files 92 93 +1
Lines 4112 4138 +26
==============================================
+ Hits 3606 3631 +25
- Misses 506 507 +1 |
shalehaha
approved these changes
Jan 22, 2021
| /// | ||
| public struct DefaultHeadersFormatter { | ||
|
|
||
| typealias httpHeaderConstants = HttpConnectionConstants.Header |
There was a problem hiding this comment.
do we still need this line?
| /// - Parameter unformattedLocale: The unformatted locale as a string | ||
| /// - Returns: The formatted locale as a string or nil if not able to format it. | ||
| /// | ||
| public static func getFormattedLocale(unformattedLocale: String) -> String { |
There was a problem hiding this comment.
Decided to change the name as well. Lmk what you think.
nporter-adbe
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v5 we format the locale. Here we format the locale as in v5 except we do it in the
NetworkRequestto keep it centrally located and not rely on each extension to do it.