Add public api to register global listener #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenedicadb
reviewed
Nov 17, 2020
| @@ -94,13 +94,23 @@ public final class MobileCore: NSObject { | |||
| /// - responseCallback: Callback to be invoked with `event`'s response `Event` | |||
| @objc(dispatch:responseCallback:) | |||
| public static func dispatch(event: Event, responseCallback: @escaping (Event?) -> Void) { | |||
| EventHub.shared.registerResponseListener(triggerEvent: event, timeout: 1) { event in | |||
| EventHub.shared.registerResponseListener(triggerEvent: event, timeout: 2) { event in | |||
There was a problem hiding this comment.
should we make this timeout configurable? or at least explain that it exists in the docs for the method?
There was a problem hiding this comment.
will address this in a separate pr
Codecov Report
@@ Coverage Diff @@
## dev #451 +/- ##
==========================================
+ Coverage 87.46% 87.56% +0.10%
==========================================
Files 92 92
Lines 4050 4059 +9
==========================================
+ Hits 3542 3554 +12
+ Misses 508 505 -3 |
shalehaha
changed the title
pfransenadb
requested changes
Nov 18, 2020
| @@ -20,5 +20,9 @@ import Foundation | |||
| case callbackTimeout = 1 | |||
| case callbackNil = 2 | |||
| case none = 3 | |||
| case serverError = 4 | |||
There was a problem hiding this comment.
Are these an artifact from some other work? I don't see them used anywhere in this PR.
| /// - source: An `String` indicates the event source the current listener is listening for | ||
| /// - listener: An `EventResponseListener` which will be invoked whenever the `EventHub` receives a event with matched typd and source | ||
| func registerEventListener(type: String, source: String, listener: @escaping EventListener) { | ||
|
|
There was a problem hiding this comment.
nit: remove blank line.
| @@ -22,6 +22,7 @@ public class EventSource: NSObject { | |||
| public static let requestIdentity = "com.adobe.eventSource.requestIdentity" | |||
| public static let requestProfile = "com.adobe.eventSource.requestProfile" | |||
| public static let requestReset = "com.adobe.eventSource.requestReset" | |||
| public static let notification = "com.adobe.eventSource.notification" | |||
| @@ -34,6 +34,7 @@ public class EventType: NSObject { | |||
| public static let userProfile = "com.adobe.eventType.userProfile" | |||
| public static let places = "com.adobe.eventType.places" | |||
| public static let offerDecisioning = "com.adobe.eventType.offerDecisioning" | |||
| public static let edge = "com.adobe.eventType.edge" | |||
shalehaha
changed the title
|
@pfransenadb fixed. removed the code that is not related to this pr. |
sbenedicadb
approved these changes
Nov 19, 2020
| @@ -101,6 +101,16 @@ public final class MobileCore: NSObject { | |||
| EventHub.shared.dispatch(event: event) | |||
| } | |||
|
|
|||
| /// Registers an `EventListener` which will be invoked whenever a event with matched type and source is dispatched | |||
| /// - Parameters: | |||
| /// - type: An `String` indicates the event type the current listener is listening for | |||
There was a problem hiding this comment.
An String indicates > A String indicating
| /// Registers an `EventListener` which will be invoked whenever a event with matched type and source is dispatched | ||
| /// - Parameters: | ||
| /// - type: An `String` indicates the event type the current listener is listening for | ||
| /// - source: An `String` indicates the event source the current listener is listening for |
| /// - Parameters: | ||
| /// - type: An `String` indicates the event type the current listener is listening for | ||
| /// - source: An `String` indicates the event source the current listener is listening for | ||
| /// - listener: An `EventResponseListener` which will be invoked whenever the `EventHub` receives a event with matched typd and source |
| @@ -148,6 +148,22 @@ final class EventHub { | |||
| responseEventListeners.append(responseListenerContainer!) | |||
| } | |||
|
|
|||
| /// Registers an `EventListener` which will be invoked whenever a event with matched type and source is dispatched | |||
| /// - Parameters: | |||
| /// - type: An `String` indicates the event type the current listener is listening for | |||
There was a problem hiding this comment.
same fixes needed for copy/pasted docs
| /// - listener: An `EventResponseListener` which will be invoked whenever the `EventHub` receives a event with matched typd and source | ||
| func registerEventListener(type: String, source: String, listener: @escaping EventListener) { | ||
| eventHubQueue.async { | ||
| // use the event hub placeholder extension to hold all the listeners register from the public API |
sbenedicadb
reviewed
Nov 19, 2020
| @@ -101,6 +101,16 @@ public final class MobileCore: NSObject { | |||
| EventHub.shared.dispatch(event: event) | |||
| } | |||
|
|
|||
| /// Registers an `EventListener` which will be invoked whenever a event with matched type and source is dispatched | |||
| /// - Parameters: | |||
| /// - type: An `String` indicating the event type the current listener is listening for | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API to MobileCore to allow registering of an event listener. Mainly to support the scenario where an extension need to support a public permanent callback.