syncronize Event processing #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #436 +/- ##
==========================================
- Coverage 87.43% 87.15% -0.28%
==========================================
Files 92 92
Lines 4042 4046 +4
==========================================
- Hits 3534 3526 -8
- Misses 508 520 +12 |
shalehaha
approved these changes
Nov 2, 2020
shalehaha
reviewed
Nov 2, 2020
| Log.warning(label: LOG_TAG, "Unable to retrieve shared state for \(extensionName). No such extension is registered.") | ||
| return nil | ||
| } | ||
| return eventHubQueue.sync { |
There was a problem hiding this comment.
a little bit concerned about the performance implication but we can see if it will cause any problem
|
any feedback @sbenedicadb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all event processing onto the eventHubQueue to fix any race conditions that could result in out of order Event dispatching.