Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of recoverable network transport errors #1021

Merged
merged 3 commits into from
May 14, 2024

Conversation

addb
Copy link
Contributor

@addb addb commented May 10, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested a review from cdhoffmann May 13, 2024 17:09
@addb addb requested a review from praveek May 13, 2024 22:55
@addb addb merged commit 90e7eab into adobe:dev-v5.0.1 May 14, 2024
17 checks passed
@emdobrin
Copy link
Contributor

oops, merged while typing

@addb is the expectation that RECOVERABLE_NETWORK_TRANSPORT_ERROR_CODES will be an array of URLErrors only or could that include other NSErrors in the future?

If URLErrors only, any reason why we extract the rawValue instead of using the code directly for simplified compare/contains checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants