Skip to content

Early escape from insert/insertIfNotExists if event hash is 0 #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

spoorthipujariadobe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (d0c72be) to head (2a83693).
Report is 30 commits behind head on feature/disqualification.

Files with missing lines Patch % Lines
...obile/launch/rulesengine/LaunchRulesConsequence.kt 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feature/disqualification     #781      +/-   ##
==============================================================
+ Coverage                       75.37%   75.61%   +0.24%     
- Complexity                       2338     2345       +7     
==============================================================
  Files                             217      219       +2     
  Lines                           10889    10902      +13     
  Branches                         1411     1414       +3     
==============================================================
+ Hits                             8207     8243      +36     
+ Misses                           2051     2028      -23     
  Partials                          631      631              
Flag Coverage Δ
android-functional-tests 28.61% <0.00%> (+0.43%) ⬆️
android-unit-tests 64.43% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ing/mobile/launch/rulesengine/LaunchTokenFinder.kt 75.93% <100.00%> (ø)
...obile/launch/rulesengine/LaunchRulesConsequence.kt 89.74% <0.00%> (-0.18%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spoorthipujariadobe spoorthipujariadobe merged commit af33a30 into adobe:feature/disqualification Jul 22, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants