Fix message inset calculation for InAppMessages #778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Inset calculation for in-app messages has regressed in
v3.1.1-core
.The
MessageOffsetMapper
methods expect the full screen view dimensions as the third parameter to calculate the offset percentage correctly, but now being calculated incorrectly according to the dimensions of the in-app message rather than the dimensions of the view.This results in the following behavior:
heightDp.value equals contentHeightDp (full screen height)
the, offset calculation works correctly.heightDp.value equals contentHeightDp * 30 / 100 (30% of screen height)
Offset percentage is calculated against this smaller value, making the actual offset much smaller than intended.Solution
Ensure that verticalInset percentage is always calculated against the enclosing activity height (
contentHeightDp
) and horizontalInset against the enclosing activity width (contentWidthDp
), regardless of the message's actual size.Related Issue
PLATIR-51482
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: