Skip to content

Allow disabling timeout when registering response listener #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Feb 22, 2025

Some extensions don't want the request listener to time out when they call the API. They can achieve this by setting a large timeout. This is just a minor optimization to prevent adding additional timeout tasks for such listeners.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (47bb4e7) to head (a8e86c2).
Report is 15 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #744      +/-   ##
============================================
+ Coverage     68.98%   74.75%   +5.77%     
- Complexity     1939     2304     +365     
============================================
  Files           194      216      +22     
  Lines          8953    10667    +1714     
  Branches       1121     1385     +264     
============================================
+ Hits           6176     7974    +1798     
+ Misses         2313     2060     -253     
- Partials        464      633     +169     
Flag Coverage Δ
android-functional-tests 28.21% <0.00%> (?)
android-unit-tests 63.79% <100.00%> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...obe/marketing/mobile/internal/eventhub/EventHub.kt 86.25% <100.00%> (+0.35%) ⬆️
...ne/java/com/adobe/marketing/mobile/MobileCore.java 60.63% <ø> (-3.07%) ⬇️

... and 58 files with indirect coverage changes

@praveek praveek merged commit 8bc8c3d into adobe:dev Feb 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants