Multipart uploads do not properly handle UTF-8 encoded names

[badvision]

aem-testing-clients/src/main/java/com/adobe/cq/testing/client/CQAssetsClient.java

Line 394 in 889e1c6

.addTextBody("fileName", fileName)

When building the multipart request, the charset of the filename part is not set as UTF-8 and instead is ISO-8859-1 and the filename characters that are 3-byte UTF-8 (such as Korean and Chinese glyphs) are squashed to ? characters.

[joerghoh]

Strings in Java are UTF-8; are you sure that this squashing is not done much earlier? For example if you are on a windows platform and provide the filename via command line.

[badvision]

Yes, I'm sure. It's happening in a CentOS Jenkins environment and on my Mac.

…

On Wed, Sep 28, 2022, 11:43 AM Jörg Hoh ***@***.***> wrote: Strings in Java are UTF-8; are you sure that this squashing is not done much earlier? For example if you are on a windows platform and provide the filename via command line. — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHH5BXAILAKRBQMMGJDT6DWARYS3ANCNFSM6AAAAAAQX6NHOE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[badvision]

Specifically, the content type for the multipart of filename indicates it is text with ISO-1189-1 encoding, even though the request itself has UTF-8 encoding specified. Most tests don't pick up on this encoding snafu because lower ascii is the same in both encodings. Only multi-byte characters in the filename reveal this issue.