-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating release version of archetype for existing projects #1244
Conversation
I think it is worth explicitly mentioning immutable dispatcher files and how to update those. |
@kwin There is a script in it https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/dispatcher.cloud/update_sdk.sh for 2 years - since August 2022 via #966 by @froesef - see note in https://github.com/adobe/aem-project-archetype/releases/tag/aem-project-archetype-39 |
Perfect, would be nice to mention that in the update section then. |
@kwin It is mentioned in https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug#third-phase
|
@kwin FYI Mentioned in Updating archetype dispatcher.cloud configuration to version 2.0.232 by @krystiannowak in #1237 line in https://github.com/adobe/aem-project-archetype/releases/tag/aem-project-archetype-51 refers to the immutable files changes in the newest dispatcher-publish image and present in Dispatcher SDK tooling 2.0.232 related to SKYOPS-77603 : Management of redirects by business users in Enhancements section set in https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/release-notes/maintenance/latest for AEM CS Release 18311 |
@kwin But true @bohnertchris Would it make sense to also include in the change to mention usage of https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/dispatcher.cloud/update_sdk.sh as suggested in https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug#third-phase last paragraph or rephrase it:
e.g. as point number 5 in the proposed Updating Existing Projects to the Lastest Archetype Release section being added in this PR? cc: @froesef |
Co-authored-by: Ramon Bisswanger <ramon@bisswanger.de>
|
||
Adobe strongly recommends sufficient test coverage (including unit tests, integration tests, and end-to-end tests) to ensure that an update does not introduce unexpected behavior. | ||
|
||
## Updating Immutable Dispatcher Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@buuhuu would you please review and merge? Thank you. |
Description
Add recommendation that updating the archetype release for existing project is generally not required, along with guidance if a particular project determines that an update is required.
Related Issue
CQDOC-22106
Motivation and Context
This was not explicitly stated before. Also give opportunity to re-emphasize that keeping dependencies up-to-date is the responsibility of the individual project.
How Has This Been Tested?
It hasn't. This is a documentation change only.
Screenshots (if appropriate):
n/a
Types of changes
Checklist: