Conversation
atopper
reviewed
Oct 27, 2025
| const pathSegments = u.pathname.split('/').filter(Boolean); | ||
|
|
||
| // Look for a segment with an extension (e.g., "diabetologie.svg" in path) | ||
| let filename = null; |
Contributor
There was a problem hiding this comment.
Could you get the filename by doing something like:
const filenameWithExtension = u.pathname.split('/').pop();
Similar to line 204 but gets the last immedately.
Then extension:
const fileExtension = filenameWithExtension.split('.').pop();
I see the loop goes backwards (handling periods in path segments), which works but might be a little awkward to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: