Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-15225 Enable web optimized image delivery on image core component by default for all customers #2574

Closed
wants to merge 5 commits into from

Conversation

mohiaror
Copy link
Collaborator

Introduce a new option for customers to opt-out of the feature instead of opt-in. The new checkbox will be enabled on the basis of FT which will be governed on the basis of program ID of the customer.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

…nt by default for all customers

Introduce a new option for customers to opt-out of the feature instead of opt-in. The new checkbox will be enabled on the basis of FT which will be governed on the basis of program ID of the customer.
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vladbailescu vladbailescu added this to the 2.23.4 milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b15289) 87.32% compared to head (99f10c7) 87.33%.

❗ Current head 99f10c7 differs from pull request most recent head bbd7b8e. Consider uploading reports for the commit bbd7b8e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2574      +/-   ##
============================================
+ Coverage     87.32%   87.33%   +0.01%     
+ Complexity     2654     2649       -5     
============================================
  Files           232      232              
  Lines          7100     7077      -23     
  Branches       1080     1074       -6     
============================================
- Hits           6200     6181      -19     
- Misses          357      359       +2     
+ Partials        543      537       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha LSantha removed this from the 2.23.4 milestone Sep 13, 2023
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mohiaror
Copy link
Collaborator Author

No longer required. Closing this PR.

@mohiaror mohiaror closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants