Skip to content

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Apr 7, 2022

Description

With this change we move parts of frontend-maven-plugin configuration to the parent module to reduce duplication. We also update the version to the latest release.

Related Issue

CIF-2811
eirslett/frontend-maven-plugin#970

Motivation and Context

Support builds on Apple Silicon with node versions older than 16

How Has This Been Tested?

Build locally, CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the releng Release engineering label Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #878 (a5c3d90) into master (2954e6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #878   +/-   ##
=========================================
  Coverage     69.43%   69.43%           
  Complexity     1164     1164           
=========================================
  Files           320      320           
  Lines          8498     8498           
  Branches       1273     1273           
=========================================
  Hits           5901     5901           
  Misses         2183     2183           
  Partials        414      414           
Flag Coverage Δ
integration 54.99% <ø> (ø)
jest 86.40% <ø> (ø)
karma 95.44% <ø> (ø)
unittests 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2954e6d...a5c3d90. Read the comment docs.

@buuhuu buuhuu merged commit 1f42423 into master Apr 7, 2022
@buuhuu buuhuu deleted the issue/CIF-2811 branch April 7, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releng Release engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants