CIF-1382 - Create the Core CIF Components library pages - product com… #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent - add proxy product component for the library - add a `page` component that adds the store-view and graphql endpoint for the client-side code - add JSON mock response and images for the product component
cjelger
requested review from
mhaack,
herzog31,
dplaton,
LSantha,
laurentiumagureanu and
hbacila
dplaton
approved these changes
May 12, 2020
herzog31
approved these changes
May 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=========================================
Coverage 63.20% 63.20%
Complexity 754 754
=========================================
Files 173 173
Lines 5354 5354
Branches 840 840
=========================================
Hits 3384 3384
Misses 1855 1855
Partials 115 115
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ponent
pagecomponent that adds the store-view and graphql endpoint for the client-side code