CIF-890 - Create the Core CIF Components library pages - for server-side components #265
Conversation
…ide components - configure CIF section of the core components library
…ide components - extended documentation
…ide components - removed unneeded image - moved dependency version to parent pom
…ide components - reverted version change for the components
…ide components - extend README
…ide components - add documentation to generate the venia.css file
…ide components - fix markdown
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
============================================
- Coverage 63.20% 63.19% -0.02%
- Complexity 752 755 +3
============================================
Files 172 172
Lines 5360 5360
Branches 840 842 +2
============================================
- Hits 3388 3387 -1
Misses 1856 1856
- Partials 116 117 +1
Continue to review full report at Codecov.
|
…ide components - allow coverage to decrease by max 10%
cjelger
requested review from
herzog31,
dplaton,
mhaack,
LSantha,
laurentiumagureanu and
hbacila
…ide components - extend tests
| * | ||
| ******************************************************************************/ | ||
| /******************************************************************************* | ||
| * ADOBE CONFIDENTIAL |
There was a problem hiding this comment.
This file is generated: this header is coming from one of the css file, actually https://github.com/adobe/aem-cif-project-archetype/blob/master/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appsFolderName__/clientlibs/theme/components/minicart/flow.css but there might be more with the "wrong" header. I didn't want to use any plugin to remove headers/comments or minimise the file: I'd rather invest more time to automate this in a separate issue.
| <jcr:root xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | ||
| jcr:primaryType="cq:ClientLibraryFolder" | ||
| allowProxy="{Boolean}true" | ||
| categories="[venia-theme]"/> |
There was a problem hiding this comment.
Shouldn't we use a different name instead of "Venia"?
Before you ask, I don't have another suggestion :)
There was a problem hiding this comment.
I'd keep venia, we do really use the venia theme from the archetype. ;-)
examples/pom.xml
Outdated
| <groupId>com.adobe.commerce.cif</groupId> | ||
| <artifactId>core-cif-components-parent</artifactId> | ||
| <version>0.10.2-SNAPSHOT</version> | ||
| <relativePath>parent/pom.xml</relativePath> |
There was a problem hiding this comment.
This should be ../parent/pom.xml
…ide components - minor fix
This creates the basic content required to extend the WCM Core Component Library with commerce components. The PR includes a first example with the
productcomponent, that will have to be extended in follow-up PRs for all the CIF components.How Has This Been Tested?
Manually tested.
Screenshots (if appropriate):
Types of changes
Checklist: