Skip to content

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Mar 26, 2020

  • use default quantities of grouped products

How Has This Been Tested?

Extended unit tests and manually tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

cjelger added 3 commits March 26, 2020 09:57
- use default quantities of grouped products
- enable/disable add-to-cart on load based on product quantities
@cjelger cjelger added the bug Something isn't working label Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
+ Coverage     61.25%   61.37%   +0.11%     
- Complexity      557      566       +9     
============================================
  Files           149      150       +1     
  Lines          4556     4570      +14     
  Branches        758      758              
============================================
+ Hits           2791     2805      +14     
  Misses         1680     1680              
  Partials         85       85
Flag Coverage Δ Complexity Δ
#jest 40.94% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.82% <100%> (ø) 0 <0> (ø) ⬇️
#unittests 85.72% <100%> (+0.13%) 566 <9> (+9) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ents/internal/models/v1/product/GroupItemImpl.java 100% <100%> (ø) 9 <9> (?)
...onents/internal/models/v1/product/ProductImpl.java 86.6% <100%> (+0.12%) 42 <0> (ø) ⬇️
...merce/product/v1/product/clientlib/js/addToCart.js 97.56% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62ec2c...e979519. Read the comment docs.

@mhaack mhaack merged commit ae20b21 into master Mar 30, 2020
@mhaack mhaack deleted the CIF-1334 branch March 30, 2020 13:24
@mhaack mhaack added verified and removed To Verify labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants