Skip to content

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Feb 21, 2020

  • remove "hard-coded" category page link for top categories

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- remove "hard-coded" category page link for top categories
@cjelger cjelger added the bug Something isn't working label Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #208 into master will decrease coverage by 0.03%.
The diff coverage is 51.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #208      +/-   ##
===========================================
- Coverage     59.44%   59.4%   -0.04%     
  Complexity      529     529              
===========================================
  Files           146     147       +1     
  Lines          4318    4336      +18     
  Branches        730     736       +6     
===========================================
+ Hits           2567    2576       +9     
- Misses         1659    1668       +9     
  Partials         92      92
Flag Coverage Δ Complexity Δ
#jest 37.6% <45%> (+0.04%) 0 <0> (ø) ⬇️
#karma 94.97% <100%> (+0.01%) 0 <0> (ø) ⬇️
#unittests 84.32% <100%> (+0.01%) 529 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...onents/internal/models/v1/product/ProductImpl.java 83.87% <ø> (ø) 33 <0> (ø) ⬇️
...nternal/models/v1/productlist/ProductListImpl.java 77.55% <ø> (ø) 33 <0> (ø) ⬇️
...omponents/src/components/Minicart/totalsSummary.js 14.28% <0%> (-10.72%) 0 <0> (ø)
react-components/src/components/Minicart/body.js 44.44% <0%> (-8.89%) 0 <0> (ø)
react-components/src/components/Minicart/footer.js 20% <0%> (ø) 0 <0> (ø) ⬇️
...-components/src/components/Minicart/cartOptions.js 52.38% <100%> (ø) 0 <0> (ø) ⬇️
...models/v1/product/ProductPlaceholderRetriever.java 85.71% <100%> (ø) 1 <0> (ø) ⬇️
...s/v1/productlist/CategoryPlaceholderRetriever.java 85.71% <100%> (ø) 1 <0> (ø) ⬇️
...models/v1/productcarousel/ProductCarouselImpl.java 70.83% <100%> (+0.62%) 14 <0> (ø) ⬇️
...eact-components/src/components/Minicart/product.js 78.94% <100%> (ø) 0 <0> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e90f74...1527114. Read the comment docs.

@dplaton dplaton merged commit a456052 into master Feb 24, 2020
@dplaton dplaton deleted the CIF-1290 branch February 24, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants