Skip to content

Conversation

herzog31
Copy link
Member

Description

  • Cart totals now respect discounts.
  • Display line item and total prices that also respect discounts.
  • Display list of applied discounts.

How Has This Been Tested?

  • Jest tests updated

Screenshots (if appropriate):

Screenshot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the enhancement New feature or request label Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #207 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #207      +/-   ##
===========================================
+ Coverage     59.39%   59.4%   +<.01%     
  Complexity      529     529              
===========================================
  Files           147     147              
  Lines          4334    4335       +1     
  Branches        736     736              
===========================================
+ Hits           2574    2575       +1     
  Misses         1668    1668              
  Partials         92      92
Flag Coverage Δ Complexity Δ
#jest 37.6% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.97% <100%> (+0.01%) 0 <0> (ø) ⬇️
#unittests 84.3% <ø> (ø) 529 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...vigation/v1/navigation/clientlibs/js/navigation.js 98.66% <100%> (+0.01%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ac77b...4b3fded. Read the comment docs.

@herzog31 herzog31 added this to the Magento 2.3.4 milestone Feb 20, 2020
@dplaton dplaton merged commit 7fc4df4 into master Feb 21, 2020
@dplaton dplaton deleted the issue/CIF-1154 branch February 21, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants