CIF-1282 - Navigation header is broken for empty navigation

[LSantha]

• fixed navigation header for empty navigation

Related Issue

CIF-1282

How Has This Been Tested?

Manually, unit test

Screenshots:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes and the overall coverage did not decrease.
• All unit tests pass on CircleCi.
• I ran all tests locally and they pass.

[codecov]

Codecov Report

Merging #205 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #205   +/-   ##
=========================================
  Coverage     59.44%   59.45%           
  Complexity      529      529           
=========================================
  Files           146      146           
  Lines          4318     4319    +1     
  Branches        730      730           
=========================================
+ Hits           2567     2568    +1     
  Misses         1659     1659           
  Partials         92       92           

Flag	Coverage Δ	Complexity Δ
#jest	37.56% <ø> (ø)	0.00 <ø> (ø)	⬆️
#karma	94.97% <100.00%> (+0.01%)	0.00 <0.00> (ø)	⬆️
#unittests	84.30% <ø> (ø)	529.00 <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f3292...44bb90f. Read the comment docs.

[herzog31]

LGTM.

But how are the npm updates related to your changes?

[LSantha]

@herzog31 , npm reported a lot of issues with the dependencies, so that's an attempt to improve it.

[herzog31]

@LSantha What kind of issues? For me, npm doesn't show anything. Not even vulnerabilities.

[LSantha]

@herzog31 ,
On master branch in the the ui.apps folder npm install reports this for me:
found 193 vulnerabilities (4 low, 188 moderate, 1 high)

On the feature branch the same command reports:
found 5 vulnerabilities (2 low, 2 moderate, 1 high)