Skip to content

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Feb 17, 2020

Description

How Has This Been Tested?

  • Manual and updated unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • X ] I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #203 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
+ Coverage     59.38%   59.44%   +0.06%     
+ Complexity      532      529       -3     
============================================
  Files           146      146              
  Lines          4331     4318      -13     
  Branches        732      730       -2     
============================================
- Hits           2572     2567       -5     
+ Misses         1662     1659       -3     
+ Partials         97       92       -5     
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0.00 <ø> (ø) ⬆️
#karma 94.96% <ø> (ø) 0.00 <ø> (ø) ⬆️
#unittests 84.30% <100.00%> (+0.39%) 529.00 <6.00> (-3.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce60bc...5adfb62. Read the comment docs.

@dplaton dplaton merged commit 21aef6b into master Feb 20, 2020
@dplaton dplaton deleted the issue/CIF-1251 branch February 20, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants