Skip to content

Conversation

mhaack
Copy link
Contributor

@mhaack mhaack commented Feb 17, 2020

Description

Fix featured category placeholder display in publish mode. The component was switched to the WCM core components placeholder template and displays two different placeholders, based on the state. The component distinguishes between configured vs. not configured and configured but no category data available.

Author (edit): placeholder if not configured or configured but no category data
Author (preview) & publish: no place holder

Related Issue

CIF-1231

Motivation and Context

Don't display placeholders on publish and unify placeholder usage.

Screenshots (if appropriate):

Component not configured:
Screenshot 2020-02-17 at 11 56 57

Component configured, but no category data availbale:
Screenshot 2020-02-17 at 11 57 26

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@mhaack mhaack added the bug Something isn't working label Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #200 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
- Coverage     59.29%   59.26%   -0.04%     
- Complexity      526      527       +1     
============================================
  Files           146      146              
  Lines          4331     4330       -1     
  Branches        726      726              
============================================
- Hits           2568     2566       -2     
  Misses         1666     1666              
- Partials         97       98       +1     
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0.00 <ø> (ø) ⬆️
#karma 94.96% <ø> (ø) 0.00 <ø> (ø) ⬆️
#unittests 83.56% <80.00%> (-0.08%) 527.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f4384...4227e49. Read the comment docs.

@dplaton dplaton merged commit bb622fe into master Feb 18, 2020
@dplaton dplaton deleted the issues/CIF-1231 branch February 18, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants