Skip to content

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Feb 13, 2020

  • removed all "default" methods in sling model interfaces

- removed all "default" methods in sling model interfaces
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #199 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #199      +/-   ##
============================================
+ Coverage     59.06%   59.29%   +0.23%     
  Complexity      526      526              
============================================
  Files           149      146       -3     
  Lines          4348     4331      -17     
  Branches        726      726              
============================================
  Hits           2568     2568              
+ Misses         1683     1666      -17     
  Partials         97       97
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.96% <ø> (-5.04%) 0 <ø> (ø)
#unittests 83.64% <ø> (+0.93%) 526 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ctteaser/v1/productteaser/clientlibs/js/actions.js 92.3% <0%> (ø) 0% <0%> (ø) ⬇️
...merce/product/v1/product/clientlib/js/addToCart.js 96.42% <0%> (ø) 0% <0%> (ø) ⬇️
...ommerce/product/v1/product/clientlib/js/gallery.js 94.87% <0%> (ø) 0% <0%> (ø) ⬇️
...vigation/v1/navigation/clientlibs/js/navigation.js 98.64% <0%> (ø) 0% <0%> (ø) ⬇️
...ps/core/cif/clientlibs/common/js/PriceFormatter.js 90.9% <0%> (ø) 0% <0%> (ø) ⬇️
...ommerce/product/v1/product/clientlib/js/product.js 96.29% <0%> (ø) 0% <0%> (ø) ⬇️
...ctlist/v1/productlist/clientlibs/js/productlist.js 93.61% <0%> (ø) 0% <0%> (ø) ⬇️
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 88.33% <0%> (ø) 0% <0%> (ø) ⬇️
...product/v1/product/clientlib/js/variantSelector.js 98.3% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da6f2e...e1a7e61. Read the comment docs.

@mhaack mhaack added the enhancement New feature or request label Feb 17, 2020
@mhaack mhaack merged commit 12f4384 into master Feb 17, 2020
@mhaack mhaack deleted the CIF-1188 branch February 17, 2020 09:15
@mhaack
Copy link
Contributor

mhaack commented Feb 17, 2020

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants