Skip to content

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Feb 3, 2020

Description

How Has This Been Tested?

  • Updated Java unit tests
  • Updated Karma tests

Screenshots:

Imgur

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #194 into master will increase coverage by 12.4%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
+ Coverage     45.95%   58.36%   +12.4%     
- Complexity        0      501     +501     
============================================
  Files           100      149      +49     
  Lines          2807     4280    +1473     
  Branches        561      726     +165     
============================================
+ Hits           1290     2498    +1208     
- Misses         1517     1683     +166     
- Partials          0       99      +99
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.89% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 82% <ø> (?) 501 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...models/v1/relatedproducts/RelatedProductsImpl.java 85.36% <0%> (ø) 14% <0%> (?)
...ts/models/retriever/AbstractCategoryRetriever.java 94.44% <0%> (ø) 15% <0%> (?)
...e/components/internal/models/v1/HeroImageImpl.java 0% <0%> (ø) 0% <0%> (?)
.../models/retriever/AbstractCategoriesRetriever.java 89.47% <0%> (ø) 14% <0%> (?)
...mponents/internal/models/v1/product/AssetImpl.java 73.68% <0%> (ø) 10% <0%> (?)
.../models/v1/navigation/GraphQLCategoryProvider.java 100% <0%> (ø) 13% <0%> (?)
...components/models/retriever/AbstractRetriever.java 71.42% <0%> (ø) 2% <0%> (?)
...s/internal/models/v1/product/VariantValueImpl.java 100% <0%> (ø) 5% <0%> (?)
...ernal/servlets/GraphqlClientDataSourceServlet.java 90.9% <0%> (ø) 6% <0%> (?)
...rnal/models/v1/productteaser/ProductRetriever.java 84.61% <0%> (ø) 12% <0%> (?)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ec1b4...bc12a83. Read the comment docs.

@mhaack mhaack merged commit 76e7f9a into master Feb 10, 2020
@mhaack mhaack deleted the issue/CIF-1196 branch February 10, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants