-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-1196 - Update pricing information on product component #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
============================================
+ Coverage 45.95% 58.36% +12.4%
- Complexity 0 501 +501
============================================
Files 100 149 +49
Lines 2807 4280 +1473
Branches 561 726 +165
============================================
+ Hits 1290 2498 +1208
- Misses 1517 1683 +166
- Partials 0 99 +99
Continue to review full report at Codecov.
|
dplaton
approved these changes
Feb 7, 2020
mhaack
reviewed
Feb 10, 2020
...ps/src/main/content/jcr_root/apps/core/cif/components/commerce/product/v1/product/price.html
Outdated
Show resolved
Hide resolved
mhaack
reviewed
Feb 10, 2020
...ps/src/main/content/jcr_root/apps/core/cif/components/commerce/product/v1/product/price.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
priceRange
property provided by Magento 2.3.4 GraphQL schema to display more detailed product pricing.How Has This Been Tested?
Screenshots:
Types of changes
Checklist: