Skip to content

Conversation

herzog31
Copy link
Member

Description

In the Magento 2.3.4 schema, the product query no longer accepts ProductFilterInput instances. All occurrences needed to be replaced with the new ProductAttributeFilterInput since otherwise the build fails.

How Has This Been Tested?

  • Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Jan 30, 2020
@herzog31 herzog31 added this to the Magento 2.3.4 milestone Jan 30, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #186 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage     58.04%   58.04%           
  Complexity      482      482           
=========================================
  Files           148      148           
  Lines          4205     4205           
  Branches        724      724           
=========================================
  Hits           2441     2441           
  Misses         1670     1670           
  Partials         94       94           
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0.00 <ø> (ø) ⬆️
#karma 94.53% <ø> (ø) 0.00 <ø> (ø) ⬆️
#unittests 82.66% <100.00%> (ø) 482.00 <7.00> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea149be...db27d53. Read the comment docs.

@mhaack mhaack added verified and removed To Verify labels Feb 5, 2020
@mhaack
Copy link
Contributor

mhaack commented Feb 5, 2020

Verified together with adobe/commerce-cif-connector#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants