Skip to content

Conversation

herzog31
Copy link
Member

Description

  • Move options to show/hide the title and category banner of the productlist component was moved from the design dialog to the regular edit dialog to enable changing the properties on a per component granularity.
  • This allows authors to disable the category banner and replace it by a custom image component.

How Has This Been Tested?

Manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the enhancement New feature or request label Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #180 into master will increase coverage by 1.08%.
The diff coverage is 95.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     56.79%   57.87%   +1.08%     
- Complexity      462      473      +11     
============================================
  Files           147      148       +1     
  Lines          4069     4183     +114     
  Branches        709      718       +9     
============================================
+ Hits           2311     2421     +110     
  Misses         1669     1669              
- Partials         89       93       +4
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.53% <100%> (+0.98%) 0 <0> (ø) ⬇️
#unittests 82.53% <89.47%> (+0.29%) 473 <7> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...vigation/v1/navigation/clientlibs/js/navigation.js 98.64% <100%> (ø) 0 <0> (?)
...dels/v1/categorylist/FeaturedCategoryListImpl.java 82.22% <82.14%> (+2.22%) 10 <0> (+5) ⬆️
.../internal/models/v1/navigation/NavigationImpl.java 86.2% <96.55%> (+3.03%) 23 <7> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e881f4...9006957. Read the comment docs.

@cjelger cjelger merged commit d1bb709 into master Jan 23, 2020
@cjelger cjelger deleted the issue/CIF-1151-hide-options branch January 23, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants