CIF-1129 - Option 'Show main categories' is broken #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide property type in catalog page properties
# Conflicts: # ui.apps/src/main/content/jcr_root/apps/core/cif/components/structure/catalogpage/v1/catalogpage/_cq_dialog/.content.xml
* fix the type of showMainCategories attribute value
* fix catalog page children in navigation
* changed label and field description * improved posting logic to ensure that the JCR property always has a value
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
============================================
+ Coverage 56.96% 56.97% +0.01%
Complexity 468 468
============================================
Files 147 147
Lines 4085 4084 -1
Branches 711 710 -1
============================================
Hits 2327 2327
+ Misses 1668 1667 -1
Partials 90 90
Continue to review full report at Codecov.
|
dplaton
approved these changes
Jan 13, 2020
mhaack
approved these changes
Jan 13, 2020
| if (isCatalogRoot(page)) { | ||
| item = new CatalogPageNavigationItem(null, page, currentWcmItem); | ||
| } else { | ||
| String title = currentWcmItem.getTitle(); |
There was a problem hiding this comment.
Only cosmetics and optimized by the compiler but these three variables are not really needed. Code can be reduced to one line.
herzog31
approved these changes
Jan 13, 2020
* fixed label and field description
- changed to "catalog page" to be consistent with the naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
CIF-1129, CIF-1130
How Has This Been Tested?
Manually, unti testing.
Types of changes
Checklist: