Skip to content

Conversation

dplaton
Copy link
Contributor

@dplaton dplaton commented Jan 8, 2020

Description

The user has no way to close the error panel in the minicart without refreshing the page. Adding a simple "Close" button fixed the issue.

Related Issue

CIF-1186

Motivation and Context

Recover the Minicart UI from the error state.

How Has This Been Tested?

Functional testing

Screenshots (if appropriate):

Screenshot 2020-01-08 13 49 29

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…the page

Add a "close" button to the error pane.
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.51%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
- Coverage     57.29%   56.78%   -0.52%     
  Complexity      462      462              
============================================
  Files           145      147       +2     
  Lines          3995     4070      +75     
  Branches        690      710      +20     
============================================
+ Hits           2289     2311      +22     
- Misses         1617     1670      +53     
  Partials         89       89
Flag Coverage Δ Complexity Δ
#jest 37.54% <95.45%> (-0.27%) 0 <0> (ø)
#karma 93.54% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 82.24% <ø> (ø) 462 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ts/src/components/ChangePassword/changePassword.js 100% <100%> (ø) 0 <0> (?)
...nents/src/queries/mutation_change_password.graphql 12.5% <100%> (ø) 0 <0> (?)
react-components/src/context/UserContext.js 95.52% <80%> (+1.15%) 0 <0> (ø) ⬇️
...nents/src/components/LoadingIndicator/indicator.js 100% <0%> (+50%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e22b24...f35f946. Read the comment docs.

@herzog31 herzog31 added the bug Something isn't working label Jan 8, 2020
@cjelger cjelger merged commit 311894b into master Jan 10, 2020
@cjelger cjelger deleted the issue/CIF-1186 branch January 10, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants