Skip to content

Conversation

herzog31
Copy link
Member

Description

  • Added "Change Password" menu item to my account page.
  • Added form to let logged in shoppers change their passwords.

How Has This Been Tested?

  • Unit tests
  • Manual testing

Screenshots:

Screenshot
Screenshot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the feature New feature or request label Dec 19, 2019
@herzog31 herzog31 requested review from dplaton and mhaack December 19, 2019 14:27
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #170 into master will increase coverage by 1.46%.
The diff coverage is 89.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     55.38%   56.85%   +1.46%     
- Complexity      406      462      +56     
============================================
  Files           142      147       +5     
  Lines          3893     4065     +172     
  Branches        688      708      +20     
============================================
+ Hits           2156     2311     +155     
- Misses         1654     1665      +11     
- Partials         83       89       +6
Flag Coverage Δ Complexity Δ
#jest 37.62% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 93.54% <92.3%> (-0.12%) 0 <0> (ø)
#unittests 82.24% <88.67%> (+0.89%) 462 <58> (+56) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ls/v1/storeviewexporter/StoreViewExporterImpl.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...al/models/v1/categorylist/CategoriesRetriever.java 100% <ø> (ø) 4 <0> (?)
...models/v1/productcarousel/ProductCarouselImpl.java 71.73% <0%> (-5.01%) 12 <2> (+1)
...onents/models/productcarousel/ProductCarousel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/core/components/client/MagentoGraphqlClient.java 93.1% <100%> (+1.1%) 9 <0> (+2) ⬆️
...nal/models/v1/productteaser/ProductTeaserImpl.java 58% <66.66%> (+0.55%) 16 <2> (+2) ⬆️
...dels/v1/categorylist/FeaturedCategoryListImpl.java 80% <83.33%> (+2.22%) 5 <2> (-1) ⬇️
...models/v1/relatedproducts/RelatedProductsImpl.java 87.5% <87.5%> (ø) 13 <13> (?)
.../models/retriever/AbstractCategoriesRetriever.java 89.47% <89.47%> (ø) 14 <14> (?)
...ctteaser/v1/productteaser/clientlibs/js/actions.js 92.3% <92.3%> (ø) 0 <0> (?)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737abab...a6e9732. Read the comment docs.

Copy link
Contributor

@dplaton dplaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjelger cjelger merged commit 252a71b into master Jan 9, 2020
@cjelger cjelger deleted the issue/CIF-1183 branch January 9, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants