Skip to content

Conversation

herzog31
Copy link
Member

Description

  • Fixes "Country US is not an available country" error in address forms during checkout.

How Has This Been Tested?

  • Manual testing
  • Updated unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #160 into master will increase coverage by 0.96%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     54.92%   55.89%   +0.96%     
  Complexity      406      406              
============================================
  Files           140      140              
  Lines          3814     3818       +4     
  Branches        665      668       +3     
============================================
+ Hits           2095     2134      +39     
+ Misses         1636     1601      -35     
  Partials         83       83
Flag Coverage Δ Complexity Δ
#jest 37.89% <77.77%> (+1.62%) 0 <0> (ø) ⬇️
#karma 93.66% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 81.34% <ø> (ø) 406 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
react-components/src/utils/hooks.js 94.44% <100%> (ø) 0 <0> (ø) ⬇️
...components/src/components/Checkout/editableForm.js 43.24% <71.42%> (+40.38%) 0 <0> (ø) ⬇️
...-components/src/components/Checkout/addressForm.js 76.47% <0%> (+52.94%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfb16b...0046987. Read the comment docs.

@herzog31 herzog31 added To Verify bug Something isn't working labels Dec 18, 2019
@mhaack
Copy link
Contributor

mhaack commented Dec 19, 2019

Veryfied

@mhaack mhaack added verified and removed To Verify labels Dec 19, 2019
@mhaack mhaack merged commit dd6052c into master Dec 19, 2019
@mhaack mhaack deleted the issue/CIF-1120 branch December 19, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants