Skip to content

Conversation

dplaton
Copy link
Contributor

@dplaton dplaton commented Sep 9, 2019

Clean-up the linting errors: update props validation and remove left-over console.log messages.

Description

Clean-up all the linting errors by updating props and removing console.log messages. We allowed warning and error messages as a very crude form of error reporting.

Related Issue

CIF-965

Motivation and Context

How Has This Been Tested?

npm run lint reports no errors or warnings.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Clean-up the linting errors: update props validation and remove left-over `console.log` messages.
@dplaton dplaton requested a review from mhaack September 9, 2019 09:10
@codecov-io
Copy link

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     82.63%   82.63%           
  Complexity      336      336           
=========================================
  Files            38       38           
  Lines          1307     1307           
  Branches        102      102           
=========================================
  Hits           1080     1080           
  Misses          158      158           
  Partials         69       69
Flag Coverage Δ Complexity Δ
#karma 93.61% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 79.6% <ø> (ø) 336 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3f585...472eb0c. Read the comment docs.

@mhaack mhaack merged commit bdc2d44 into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the issue/CIF-965 branch September 9, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants