Skip to content

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Mar 7, 2025

  • removed usages of com.google.common.collect (Guava)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * removed usages of com.google.common.collect (Guava)
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (fece217) to head (852ca70).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...erce/core/components/client/DeniedHttpHeaders.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1033      +/-   ##
============================================
- Coverage     88.83%   88.82%   -0.01%     
  Complexity     2391     2391              
============================================
  Files           366      366              
  Lines         10636    10639       +3     
  Branches       1539     1539              
============================================
+ Hits           9448     9450       +2     
- Misses          834      835       +1     
  Partials        354      354              
Flag Coverage Δ
integration 48.56% <80.00%> (+<0.01%) ⬆️
jest 86.68% <ø> (ø)
karma 95.58% <ø> (ø)
unittests 86.98% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@alwinjoseph02 alwinjoseph02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@LSantha LSantha merged commit 1c2abc2 into master Mar 10, 2025
19 checks passed
@LSantha LSantha deleted the SITES-29602 branch March 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants