SITES-21278: Adds Invalidation for in-memory & dispatcher cache #1023

alwinjoseph02 · 2024-12-03T11:09:46Z

No description provided.

LSantha · 2024-12-03T11:12:36Z

...java/com/adobe/cq/commerce/core/cacheInvalidation/internal/InvalidateCacheEventListener.java

+ *    governing permissions and limitations under the License.
+ *
+ ******************************************************************************/
+package com.adobe.cq.commerce.core.cacheInvalidation.internal;


Let's use lowercase package names: cacheinvalidation

* sonar fixes * osgi config * Test class * formatting code * SITES-21278: Adds the required method * sonar fixes for flush method * SITES-21278: Register the listener based on folder property * SITES-21278: Adds config for dispatcher impl * removing of osgi config code --------- Co-authored-by: Alwin Joseph <aljoseph@adobe.com>

…e/SITES-21278

* updated cif ask api version

LSantha · 2025-02-13T15:44:11Z

.../jcr_root/apps/core/cif/components/structure/page/v3/page/clientlibs/dialog/js/clearcache.js

+            contentType: 'application/json',
+            data: JSON.stringify({ storePath: storePath }),
+            success: function() {
+                showDialog(Granite.I18n.get('Cache cleared successfully!'));


It would provide a better user experience to use dialog variants here.
See https://developer.adobe.com/experience-manager/reference-materials/6-5/coral-ui/coralui3/Coral.Dialog.html
For success message use the success variant.

LSantha · 2025-02-13T15:44:26Z

.../jcr_root/apps/core/cif/components/structure/page/v3/page/clientlibs/dialog/js/clearcache.js

+                showDialog(Granite.I18n.get('Cache cleared successfully!'));
+            },
+            error: function() {
+                showDialog(Granite.I18n.get('Failed to clear cache!'));


For error use the error dialog variant.

LSantha · 2025-02-13T15:45:50Z

.../jcr_root/apps/core/cif/components/structure/page/v3/page/clientlibs/dialog/js/clearcache.js

+            },
+            footer: {
+                innerHTML:
+                    '<button is="coral-button" variant="primary" coral-close>' + Granite.I18n.get('OK') + '</button>'


For error dialog it would work better to have a 'Close' button instead of an 'OK' button.

LSantha · 2025-02-13T16:18:30Z

...ain/content/jcr_root/apps/core/cif/components/structure/page/v3/page/_cq_dialog/.content.xml

+                                                            jcr:primaryType="nt:unstructured"
+                                                            sling:resourceType="granite/ui/components/coral/foundation/button"
+                                                            text="Clear Cache"
+                                                            variant="primary"


I would suggest variant="secondary" to look more like the "cancel" button in the action bar rather than the primary "save&close" button.

LSantha · 2025-02-13T16:24:47Z

...ain/content/jcr_root/apps/core/cif/components/structure/page/v3/page/_cq_dialog/.content.xml

+                                                        jcr:primaryType="nt:unstructured"
+                                                        sling:resourceType="core/cif/components/renderconditions/pagetype"
+                                                        pageType="landing"/>
+                                                <granite:rendercondition


If you check in crx/de these two granite:rendercondition nodes are merged into one node in the repo in an inappropriate way. Each sibling node should have a distinct name. Please use one node only and use the predefined 'and' or 'or' render conditions (like at "magentoSection" further down in this .content.xml) which support multiple render conditions as child nodes and perform a boolean operation on them.

LSantha · 2025-02-13T16:29:42Z

...java/com/adobe/cq/commerce/core/cacheinvalidation/internal/InvalidateCacheButtonServlet.java

+        "sling.servlet.methods=GET",
+        "sling.servlet.extensions=html"
+    })
+public class InvalidateCacheButtonServlet extends SlingSafeMethodsServlet {


Let's name this ClearCacheButtonRenderConditionServlet.

LSantha · 2025-02-13T16:31:26Z

...java/com/adobe/cq/commerce/core/cacheinvalidation/internal/InvalidateCacheButtonServlet.java

+    })
+public class InvalidateCacheButtonServlet extends SlingSafeMethodsServlet {
+
+    public static final String RESOURCE_TYPE = "core/cif/components/renderconditions/dispatcherConfigCondition";


Use "core/cif/components/renderconditions/clearcachebutton".

LSantha · 2025-02-13T16:32:24Z

...java/com/adobe/cq/commerce/core/cacheinvalidation/internal/InvalidateCacheButtonServlet.java

+    protected void doGet(@Nonnull SlingHttpServletRequest request, @Nonnull SlingHttpServletResponse response) {
+        boolean conditionMet = invalidateCacheSupport != null;
+        if (!conditionMet) {
+            LOGGER.error("InvalidateCacheSupport service is not available");


Avoid logging error here. This is normal if a customer is not using this feature and it's not enabled.

LSantha · 2025-02-13T16:33:59Z

...rc/main/java/com/adobe/cq/commerce/core/cacheinvalidation/spi/CacheInvalidationStrategy.java

+package com.adobe.cq.commerce.core.cacheinvalidation.spi;
+
+import org.osgi.annotation.versioning.ConsumerType;
+


Add javadoc for this interface.

LSantha · 2025-02-13T16:34:28Z

...rc/main/java/com/adobe/cq/commerce/core/cacheinvalidation/spi/CacheInvalidationStrategy.java

+
+@ConsumerType
+public interface CacheInvalidationStrategy {
+    String getPattern();


Add javadoc for this method.

LSantha · 2025-02-13T16:35:01Z

...va/com/adobe/cq/commerce/core/cacheinvalidation/spi/DispatcherCacheInvalidationStrategy.java

+
+import com.day.cq.wcm.api.Page;
+
+@ConsumerType


Please add javadoc for this interface and all its methods.

LSantha · 2025-02-17T10:13:00Z

...ava/com/adobe/cq/commerce/core/cacheinvalidation/internal/InvalidateDispatcherCacheImpl.java

+    private InvalidateCacheRegistry invalidateCacheRegistry;
+
+    public void invalidateCache(String path) {
+        // To Do: Change this to for non-author run modes


Is this comment consistent with the code?

LSantha · 2025-02-17T11:01:15Z

@alwinjoseph02 , great work so far!

SITES-21278: Adds Invalidation for in-memory & dispatcher cache

0c71fb2

alwinjoseph02 requested a review from LSantha December 3, 2024 11:09

LSantha reviewed Dec 3, 2024

View reviewed changes

alwinjoseph02 and others added 27 commits December 10, 2024 22:21

SITES-21278: Optimizing the code

1f14b90

SITES-21278: Optimize the productInvalidPaths

ee8b6c4

SITES-21278: Optimize the categorybasedInvalidPaths methods

602c33d

SITES-21278: Optimize the graphql request

50c1daf

SITES-21278: Optimize the code

5279ee6

SITES-21278: Removes the type impl

dc739d7

SITES-21278: Adds the ui part for ckearing cache

ce80cd2

SITES-21278: Ui related changes

790b024

SITES:21278: Adds conffiguration & optimize the code

4727dba

SITES-21278: Adds the respective indexes config

6b631f2

SITES-21278: Formatting the code

f575389

Merge the master branch

a172ad8

SITES-21278: Adds require configuration policy cachesupport class

b09d2b3

SITES-21278: Imp the session close

aa96d4b

hide and show of clear-cache button

eaf2013

Merge remote-tracking branch 'origin/feature/SITES-21278' into featur…

b26644b

…e/SITES-21278

SITES-21278: Adds extensibility

5ba6b31

SITES-21278: Updates the extensibility based on review

03bbb0d

SITES-21278: Rename the subservice user

ac52f9d

SITES-21278: Rename the services folder

8fbcba4

* fixed invalidation entry name

e4aeec5

* updated cif ask api version

SITES-21278: Resolved the frontend rendering issue for clear-cache

3498adc

Removes unwanted test scenario

37efbd9

Removes the test coverage

e186de0

Resolves the firefox issue

03de3c1

SITES-21278: Resolves the code format issues

3955c99

LSantha reviewed Feb 13, 2025

View reviewed changes

alwinjoseph02 added 7 commits February 13, 2025 23:55

SITES-21278: Updates the test coverage

c074669

SITES-21278: Format the test coverage

4018600

SITES-21278: Updates the code based on the review

af1b8a9

SITES-21278: Reformat the code

6e1e11c

SITES-21278: Resolves unit test issues

2d89495

SITES-21278: Adds more test coverage

ac02348

SITES-21278: Adds more test coverage area

c67990d

alwinjoseph02 marked this pull request as ready for review February 14, 2025 12:08

LSantha and others added 3 commits February 14, 2025 17:21

Merge branch 'master' into feature/SITES-21278

7b152fb

SITES-21278: Updates the test coverage

0c86cf6

SITES-21278: Adds more test coverages

bef1eeb

alwinjoseph02 requested a review from LSantha February 15, 2025 13:20

SITES-21278: Adds more test coverage

d68c862

LSantha reviewed Feb 17, 2025

View reviewed changes

SITES-21278: Remove unwanted comment

d7dc2b9

LSantha approved these changes Feb 17, 2025

View reviewed changes

LSantha merged commit ce1c6ac into master Feb 17, 2025
19 checks passed

LSantha deleted the feature/SITES-21278 branch February 17, 2025 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SITES-21278: Adds Invalidation for in-memory & dispatcher cache #1023

SITES-21278: Adds Invalidation for in-memory & dispatcher cache #1023

Uh oh!

alwinjoseph02 commented Dec 3, 2024

Uh oh!

LSantha Dec 3, 2024 •

edited

Loading

Uh oh!

LSantha Feb 13, 2025 •

edited

Loading

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025 •

edited

Loading

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025 •

edited

Loading

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 13, 2025

Uh oh!

LSantha Feb 17, 2025

Uh oh!

LSantha commented Feb 17, 2025

Uh oh!

Uh oh!

Uh oh!

		package com.adobe.cq.commerce.core.cacheinvalidation.spi;

		import org.osgi.annotation.versioning.ConsumerType;

SITES-21278: Adds Invalidation for in-memory & dispatcher cache #1023

SITES-21278: Adds Invalidation for in-memory & dispatcher cache #1023

Uh oh!

Conversation

alwinjoseph02 commented Dec 3, 2024

Uh oh!

LSantha Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LSantha Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LSantha Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LSantha Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LSantha commented Feb 17, 2025

Uh oh!

Uh oh!

Uh oh!

LSantha Dec 3, 2024 •

edited

Loading

LSantha Feb 13, 2025 •

edited

Loading

LSantha Feb 13, 2025 •

edited

Loading

LSantha Feb 13, 2025 •

edited

Loading