Skip to content
This repository was archived by the owner on May 26, 2021. It is now read-only.

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented May 7, 2020

  • moved productlist clientlib to productcollection component

Description

The searchresult and productlist components are almost identical, except for the way they fetch products, and except for the extra title and image in the productlist component.

They should be refactored to minimise the duplication of code, also maybe for the Sling Models.

Related PR: adobe/aem-core-cif-components#263

Related Issue

CIF-1354

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * moved productlist clientlib to productcollection component
@dplaton dplaton merged commit 7bc5815 into master May 13, 2020
@dplaton dplaton deleted the CIF-1354 branch May 13, 2020 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants