Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expect a contents.plist file to exist in glyphs.com.adobe.type.processedglyphs #1702

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

frankrolf
Copy link
Member

Description

ufotools was assuming the contents.plist file to always exist in glyphs.com.adobe.type.processedglyphs, which may not be the case.

Fixes #1606

@josh-hadley
Copy link
Collaborator

It would be good to have something in the test suite that exercises this. @frankrolf can you add something? I can help if needed.

@frankrolf
Copy link
Member Author

Thank you for the offer – I will see what I can do and ask for help if needed :-)

Only the .glif file name is really needed here, reporting the glyphDirPath probably was a mistake anyway.
… which made that comparison fail
if the layer we are working on does not contain a contents.plist, load the contents.plist from the default layer.
@arialcrime
Copy link
Contributor

hello,

I just ran into this issue again and found the pull request here - thanks @frankrolf and @josh-hadley for working on this 🖤. Can’t wait to have this improvement integrated in a future AFDKO version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[checkoutlinesufo] FileNotFoundError when glyphs.com.adobe.type.processedglyphs is empty
3 participants