Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Multiple substitution with classes syntax #1651

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

khaledhosny
Copy link
Collaborator

@khaledhosny khaledhosny commented May 9, 2023

Description

Document syntax for using glyph classes in multiple substitution rules. The syntax used by GlyphsApp, and recently also supported by feaLib.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@miguelsousa
Copy link
Member

@khaledhosny Actions and other GH systems are experiencing an outage; that's why CI hasn't run yet.

@khaledhosny
Copy link
Collaborator Author

@khaledhosny Actions and other GH systems are experiencing an outage; that's why CI hasn't run yet.

This is only documentation change, though, so probably there is not much for the CI to catch anyway.

@miguelsousa
Copy link
Member

I see. Do you mind creating an issue to request supporting the new formats in makeotf?

@khaledhosny
Copy link
Collaborator Author

#1652

@khaledhosny khaledhosny changed the title Add syntax for using classes in multiple substitution rules [spec] Multiple substitution with classes syntax May 13, 2023
@skef
Copy link
Collaborator

skef commented May 16, 2023

This looks like a good extension to the syntax and we will likely add it. For now the addition seems lower priority than the ongoing VF-related work, so it will happen later. We generally try to keep the FDK current with the grammar so the doc update will happen at the same time #1652 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants