Do not assume presence of STAT.AxisValueArray #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code was originally meant to attempt some basic validation of the STAT table since a totally empty STAT isn't valid, but now fontBakery has a lot of STAT checks so they aren't all necessary to do here. A better plan is probably to check some basics if the STAT table exists, but if it doesn't exist then we should create it based on the fvar. Merging this now and will follow up with additional changes in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1282 – but on a branch (to run the tests).
This fixes #1281 , but I’d like @punchcutter to have a look – it could be that my fix is too simple.