Skip to content

[makeotfexe] Allow negative internal leading #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2021
Merged

[makeotfexe] Allow negative internal leading #1279

merged 3 commits into from
Jan 20, 2021

Conversation

kaydeearts
Copy link
Collaborator

Also updates expected output for makeotf_test.py and makeotfexe_test.py

Fixes #1227

@cjchapman cjchapman requested a review from josh-hadley January 14, 2021 00:58
josh-hadley
josh-hadley approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaydeearts !

@kaydeearts kaydeearts merged commit fc97c1a into develop Jan 20, 2021
@kaydeearts kaydeearts deleted the kd_fix_makeotf_bug1227 branch January 20, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-hadley josh-hadley josh-hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any reason why winAscent + winDescent can’t be smaller than the UPM?
2 participants
@kaydeearts @josh-hadley