-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deleting glyphs #1251
Allow deleting glyphs #1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simoncozens thanks for this. This looks good to me, but I'd like to have you rebase & make any adjustments needed to get tests passing before we get it merged, if you don't mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @simoncozens , looks good and will get this merged.
Looks like we need to iron out some issues with GitHub Actions running tests on forks. We've made a lot of updates to that whole thing since this PR was started/in Draft mode 3 months ago but there are still some details to work out.
This addresses #1234