Skip to content

Update sign.py - fixes #782 #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Update sign.py - fixes #782 #798

merged 1 commit into from
Sep 7, 2022

Conversation

Luci2015
Copy link
Collaborator

@Luci2015 Luci2015 commented Sep 7, 2022 •
edited
Loading

Summary

  • changed the logic so that the Sign extraction is done first, then the Sign connection

Testing Steps

  • have 7k or more accounts in Sign Dashboard and default 2min timeout for ldap connection
  • run UST for Sign sync and have the Sign extraction take longer than the ldap connection expiration time
  • UST should not throw the error anymore

Fixes #782

@adorton-adobe adorton-adobe merged commit 141c3e5 into adobe-apiplatform:v2 Sep 7, 2022
@Luci2015 Luci2015 changed the title Update sign.py - fixes #790 Update sign.py - fixes #782 Sep 7, 2022
@adorton-adobe adorton-adobe mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorton-adobe adorton-adobe adorton-adobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign-Sync 2.7.3 error - Unexpected LDAP failure reading group info: session terminated by server
2 participants
@Luci2015 @adorton-adobe