Skip to content

Start/end sync signals #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adorton-adobe
Copy link
Collaborator

Summary

  • GOAL: send start and and sync signals for each UMAPI target (send start on first batch and end on last batch)
  • Refactor user updates (new users, user updates, group changes, and adobe-only users) so we can identify start and end of each batch per UMAPI target
  • Primary target in separate list from secondary targets so we can execute secondary workflows before the primary
  • Update logging to reflect new workflow

Testing Steps

  • Run a test sync with more than 10 new or updated users
  • The log contains new messages to indicate when the signals are sent
  • All basic workflows (plus multi-target) are tested, but we still need to test Adobe-only edge cases such as exclude or write-file

Fixes #722

@Luci2015
Copy link
Collaborator

if one would keyboard interrupt the process (or get any unhandled exception during the sync), the end signal is not sent and have to wait for the 30min-60min timeout on next run?

@adorton-adobe
Copy link
Collaborator Author

I believe it would revert to default throttling behavior. I will bring this up in my next meeting with the platform team.

@adorton-adobe adorton-adobe merged commit 19d6e22 into adobe-apiplatform:v2 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send start/end sync signals
3 participants