Test mode for Sign sync #621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sign test mode
Added comments for explanation of Sign Test mode. Added sign_test_mode key in connector-sign-sync.yml with default value of no.
added default value for sign_test_mode of False, allowing sign_test_mode to work if key is not in config.
If Adobe only user list is used a none type exception was thrown with post sync. Fix was to handle exception if adobe-only-users- list used. Fixed to handle exception: "Post-Sync Connectors only support "sync" strategy".
This reverts commit 53d7084.
|
@mbonish Please create an issue for this and link it to this PR by adding a "fixes #xxx" line to the description. We need tracking issues for all PRs so we can track and triage bugs appropriately. |
|
Addressing this in Sign Phase II |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #637
Sign sync to has its own test mode where it will state the changes it plans to make but not execute them. sign_test_mode displays post_sync output without performing any updates. Users and user_groups will not be updated in the Sign Dashboard, but users and user groups to be changed will be displayed.
Updated connector-sign-sync.yml (comments for clarity and default value if sign_test_mode no) to the following:
#Test_mode presents post_sync output without performing any updates of users or user groups to the Sign Dashboard
# sign_test_mode possible values are yes or no. (default no)
# sign_test_mode is independent of user_sync test mode.
# Post Sync option does not run if user_sync tool is in test mode
sign_test_mode: no
Sign_test_mode is independent of user_sync test mode. UST will still need to be run in live mode for this to make sense. The post sync connector is disabled in test mode.